Closed SuslikV closed 3 years ago
Thanks for opening the PR and braving the questionable code base. This has turned up some issues in the CI pipeline. I'll look into fixing the CI and then look into testing locally.
I'm on board with the feature and just want to get these final checks. Thanks!
@SuslikV I think I have the CI fixed. I'm going to make a commit to try and trigger the build.
Code Climate has analyzed commit 41180ce1 and detected 0 issues on this pull request.
View more on Code Climate.
Merging #121 (41180ce) into master (9c443d5) will decrease coverage by
0.12%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 93.15% 93.02% -0.13%
==========================================
Files 16 16
Lines 628 631 +3
==========================================
+ Hits 585 587 +2
- Misses 43 44 +1
Impacted Files | Coverage Δ | |
---|---|---|
vidstab/VidStab.py | 92.57% <66.66%> (-0.35%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c443d5...41180ce. Read the comment docs.
LGTM
@SuslikV I'll plan to release over the weekend. Thanks for the feature
New parameter to be able to force output frame rate.
Sometimes it is inconvenient to edit 29 FPS videos. The FPS changes affects the stream length.