AdamSturge / FlailingCanary

0 stars 0 forks source link

No clear way to differentiate variables instantiated in config file from local variables #4

Closed AdamSturge closed 9 years ago

AdamSturge commented 9 years ago

I think we should have an easy way to tell if a variable is defined in the config file. This makes it easier to read other peoples code.

Some possible implementations:

JonnyLomond commented 9 years ago

All variables instantiated in config file are attributes of config. So they should always be called as config.access_token, for example. Is this enough? On 2015-04-25 8:21 PM, "AdamSturge" notifications@github.com wrote:

I think we should have an easy way to tell if a variable is defined in the config file. This makes it easier to read other peoples code.

Some possible implementations:

  • Use all caps for variable names in config file
  • append a set prefix string to variable name
  • Put all config variables in a dictionary called config. Ex.) config["access token"]

— Reply to this email directly or view it on GitHub https://github.com/JonnyLomond/FlailingCanary/issues/4.

AdamSturge commented 9 years ago

ah, then yes that's fine