search

AdamTyler / react-dice-complete

Complete dice rolling functionality and animations
http://adam-tyler.com/react-dice-complete
ISC License
79 stars 26 forks source link

PropTypes Deprecation #5

Closed Serexx closed 5 years ago

Serexx commented 6 years ago

Greetings, thanks for the work on this, made life easier :-)

React is complaining about the deprecated internal PropTypes (replaced by the separate 'prop-types' package) in Die.js and ReactDice.js

I'd rather not fork it for my current project but will if you don't want to change the master?

Serexx commented 6 years ago

I went ahead and forked it and made the change.

Also fixed a bug in die.js where this.die.classList='die' was throwing in Edge as classList is actually read-only even tho Chrome and Firefox allow it. Changed it to this.die.className='die'

My fork is here if anyone wants it

AdamTyler commented 5 years ago

PR was merged