Open AdamVStephen opened 10 months ago
There is entropy lying around in respect of the branches that get cloned and the naming of directories cross referenced between different scripts.
e.g. install-source-dependencies.sh contains references to branches 0.3 and 1.3 of OPCUA. However, build-sources.sh hard codes OPCUA_BRANCH=1.3
Clearly the intent is to allow the scripts to work with different bundles of branches.
Recommend refactoring so that (1) collections of environment variables define sets of branches (2) all scripts reference these.
There is entropy lying around in respect of the branches that get cloned and the naming of directories cross referenced between different scripts.
e.g. install-source-dependencies.sh contains references to branches 0.3 and 1.3 of OPCUA. However, build-sources.sh hard codes OPCUA_BRANCH=1.3
Clearly the intent is to allow the scripts to work with different bundles of branches.
Recommend refactoring so that (1) collections of environment variables define sets of branches (2) all scripts reference these.