AdamWelchUK / PWM85

An ATTiny version of Julian Iletts PWM5 Solar Charge Controller
GNU General Public License v3.0
47 stars 15 forks source link

PWM timer counter error correction & improvements #3

Closed couin3 closed 4 years ago

couin3 commented 4 years ago

Hi,

This request should be considered after previous pull, "Sleep Mode IDLE error correction & improvements".

Minor rewrites on PWM code; A change on GTCCR register to enable LED Pin to work as intended (complementary to Driver Pin); Minor changes in sleep code.

Same basic tests have been done. Around 380µA when fully on or off (no LED, no load on Pump)

AdamWelchUK commented 4 years ago

This is looking really good thank you. I've been testing this for a couple of days on two boards and it is working very well. Both the charge pump and the gate frequency seem unaffected and I've measured the controller at 850uA! I'm made up! I'm going to test just a little further, then I'll hopefully be able to merge. I was wondering if there was another way to contact you? Perhaps you could email me to say hello from the email link on my youtube page?

couin3 commented 4 years ago

Hi Adam,

I played with "AT85" MCU for some time one year ago, but only with marginally success. Your project helped me to reuse scattered things I had done, and linked them together. On the run, I also discovered novel approaches (128kHz, IDLE mode). I'm really glad to hear my last changes are working, as my test rig (see pic) is far from the real board.

But wait, there is more :

For the record, here are some links I found useful :

Regards, Marc RIVES

Ps: In French, "Couin" is close to the sound made by a quacking duck ;)

Le 03/03/2020 à 21:55, AdamWelchUK a écrit :

This is looking really good thank you. I've been testing this for a couple of days on two boards and it is working very well. Both the charge pump and the gate frequency seem unaffected and I've measured the controller at 850uA! I'm made up! I'm going to test just a little further, then I'll hopefully be able to merge. I was wondering if there was another way to contact you? Perhaps you could email me to say hello from the email link on my youtube page?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AdamWelchUK/PWM85/pull/3?email_source=notifications&email_token=AIRWEYHILZPUKORA6TV4CCDRFVVFZA5CNFSM4K7DFVGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVDSZA#issuecomment-594164068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRWEYB4JXZLVZSSEX44PGDRFVVFZANCNFSM4K7DFVGA.

couin3 commented 4 years ago

Intermediate version, closing