search

AdamWhiteHat / BigDecimal

An arbitrary-precision decimal (base 10) floating-point number class. Over 2.5 million downloads on NuGet!
MIT License
53 stars 15 forks source link

All tests seem to pass. #1

Closed Protiguous closed 2 years ago

Protiguous commented 3 years ago

We could really use a lot more comprehensive testing to make sure all parsing+math is correct.

AdamWhiteHat commented 3 years ago

Hey thanks for doing this.

I know that the library did need some help. I wrote some tests around it to help with that and fixed several bugs in the process, but I think I eventually got frustrated with the code at some point and couldnt find the motivation to work on it again.

I actually do have a project that I was wanting to write that needed to utilize this library, but I have put those plans on hold because I didn't complete working out all of the bugs. So this is really great. It can be a really useful library, if it can be relied upon.

I'm reviewing your code now. I have been busy at work, and I distract easily, so if I haven't accepted it or comment on this in a few days, ping me by dropping a comment asking for a progress update on this and that will get my attention and I will make sure to reserve some time get it done.

Protiguous commented 3 years ago

Sure. Glad to help! Thanks for doing the hard work in the first place. I'll create a branch and add issues if I find any.

I just did a fresh install of Windows 11, so I'm in the middle of getting my environment back to working conditions.. could be a few days before I can get back onto your project.