AdamaJava / adamajava

Other
14 stars 5 forks source link

input output format issue on qbasepileup coverage mode #304

Open ChristinaXu2017 opened 2 years ago

ChristinaXu2017 commented 2 years ago

**Describe the bug There was a option to specify the snp position file format and output format. -f Format of SNPs file [ddc1,maf,db,dccq,vcf,torrent,RNA,DNA], Def=dcc1 and --of Output file format [rows,columns]. we doubt these description is incorrect or ambiguous for coverage mode, if you check the code, coverage mode only support "tab", "vcf", "gff3" and "gtf"; also not support "--of columns".

To Reproduce

Here we tested "-f" and "--of" and three sets of SNP position file:

  1. SNP position file in txt format with tab delimiter eg. DPYD_97981343_A_C,T chr1 97981343 97981343 A C,T. Below five runs, two failed, three succeed and output the same in column format.
  1. We use same SNP position file as above but not use "--of" option, and got same results as above

4.SNP position file in MAF format. Both runs succeed and output same.

  1. SNP position file in VCF formte, below two runs get same output, the "--of" option is ignored.
    • -f vcf --of columns: run succeeds, the log file shows the input is "vcf" format.
    • -f vcf --of any: run succeeds, the log file shows the input is "vcf" format.

Expected behavior

  1. "--of columns" not work for coverage mode
  2. "txt" "columns", "maf" is not supported
  3. coverage mode should only support "tab", "vcf", "dccq", "gff3" and "gtf" format, here "dccq" is deprecated, "gff3" and "gtf" are not tested.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.