AdamaJava / adamajava

Other

14 stars 4 forks source link

style(qcommon): addresses SpotBugs and some CheckStyle issues #328

Closed holmeso closed 1 year ago

holmeso commented 1 year ago

Description

Clean-up of qcommon focussing on SpotBugs issues and some CheckStyle ones too. Removed some used code and tests.

Type of change

Please delete options that are not relevant.

[X] SpotBugs and CheckStyle fixes

How Has This Been Tested?

Existing tests pass

Are WDL Updates Required?

No

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

holmeso commented 1 year ago

Thanks for the review, I have pushed another commit reinstating one of the deleted unit tests.