AdamaJava / adamajava

Other
14 stars 4 forks source link

fix(qannotate): restore default value for HOM in confidence mode #349

Closed holmeso closed 5 months ago

holmeso commented 6 months ago

Description

Default value for HOM in confidence mode was erroneously changed in a recent PR ( #347).

This PR fixes that mistake by introducing another option homCutoff that is specifically used for the confidence mode to determine the number of homopolymers that are required to trigger a HOM value in the filter field.

And so, the options pertaining to homopolymers are now:

homWindow - sets the window size, used by HomopolymerMode, default is 100 homReportWindow - sets the window size that is included in the vcf info field. Used by HompolymersMode, default is 10 homCutoff - sets the nmber of homopolymers required to add the HOM annotation to the filter field. USed by ConfidenceMode, default is 6.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Added some unit tests. Ran code against vcf files generated by version 130 of code, and ouputs were the same (when default values were used).

Are WDL Updates Required?

nope

Checklist: