AIP 14: ChatRooms API

[zyuhel]

Here will go discussion regarding Chatrooms aip

[zyuhel]

https://github.com/Adamant-im/AIPs/blob/aip-chatrooms-api/AIPS/aip-14.md

[MaaKut]

1. Please, provide a sample of the full /api/chatrooms response.
2. In the /api/chatrooms/... response the last transaction details should be moved to a nested property:

   {
   lastTransaction: {
       id: ...,
       type: ....
   },
   participants: [...]
   }

3. Semantics of the withPayments param is not clear: does it rely on type or amount > 0?
4. BTW, do we really need withPayments? Transfers are the first class citizens in the chats now, so I can hardly imagine uses cases when withPayments needs to be false.

[zyuhel]

2. It makes sense.
3. withPayments semantics should add transfers, it doesn't matter how it will work on backend, we are discussing API AIP here.
4. May be someone will want to make chat app without token transfers, because of some regulations, but your point is valid. Maybe we should have parameter withoutPayments

[bludnic]

orderBy - order by field, same as in transaction list API, by default = timestamp:desc&

The responses received from these endpoints are not equal: /api/chatrooms/U123456 /api/chatrooms/U123456?orderBy=timestamp:desc

[bludnic]

Missing property height.

/api/chatrooms/U111111/U222222 - ok /api/chatrooms/U111111 - no height

[adamant-al]

Still not clear what withPayments or withoutPayments does. Payments means ADM transfers (type 0), or messages with rich text of ETH/DOGE/etc (type 8).

I think public KVS records of participants (as public ETH and DOGE addresses) should also be returned with some kind of parameter like fetchKVS. It will help to make transaction lists with names (user friendly).

[adamant-al]

limit — limit field, same as in transactions list API, default HUI_HUI I think default should be 25.