Adambean / gitlab-ce-ldap-sync

Synchronise users and groups (including group members) from an LDAP instance with Gitlab CE (and EE in free tier) self-hosted instance(s).
Apache License 2.0
61 stars 23 forks source link

Non-critical error after sync #10

Open frafra opened 5 years ago

frafra commented 5 years ago
[error] Gitlab failure: "namespace.route" can't be blank, "notification_email" can't be blank, "notification_email" is invalid
Adambean commented 5 years ago

I guess this is for new users being created? Which version of Gitlab are you running? (I've not tried this tool on 12 yet.)

frafra commented 5 years ago

Yes, it happens after users creation. I am testing it with GitLab 12.

Adambean commented 5 years ago

I just ran this against our updated Gitlab 12 instances today. A single new user needed to be created, and did so without any problems.

Are you certain there are valid email addresses assigned to your LDAP users, and that this tool is reading them? If it encounters a user with a non-empty but invalidly formatted email address that could cause it, so if it only happens with one user I'd inspect their object attributes to ensure they're valid.

beharbunjaku commented 5 years ago

This error occurred to me as well. In my case it was the "ghost" user from gitlab that was causing it. Try adding userNamesToIgnore: ["ghost"]. If it is not that, check the API logs. I think, this tool should ignore the "ghost" user by default, just as it does with the "root" user.

Adambean commented 5 years ago

@beharbunjaku's change has been merged in if you'd like to try it out @frafra.