search

Adambean / gitlab-ce-ldap-sync

Synchronise users and groups (including group members) from an LDAP instance with Gitlab CE (and EE in free tier) self-hosted instance(s).
Apache License 2.0
59 stars 23 forks source link

Various fix/expansion suggestions - your tool now works for us, many thanks! #12

Closed BOW-el closed 5 years ago

BOW-el commented 5 years ago

0b90093: Fix for issue #7. Please test if the script still works if UserMatchAttribute = UserUniqueAttribute in your setup or of UserMatchAttribute is not specified. These two cases should not alter the behavior of the script in any way and ensure compatibility with all existing usages. Please also review the code for all commits - I don't have any background in php and improvements are very welcome. I've tried to keep close to your programming style.

223900d: potential Fix for issue #8, I also started to get 500 Errors, but the gilab error log seems to show a race condition resulting from too many api calls. Limiting the rate is an attempt at a possible fix. @frafa, does this help with your issue? Issue forwarded to https://gitlab.com/gitlab-org/gitlab-ce/issues/64189

a4ebb96: Fixes an issue that occurs when AD username attributes contain special characters or umlauts.

e5b2d86: Fix for an issue that occurs when user_dn is empty in my Windows AD structure. This fix can be activated optionally by a boolean in the settings file.

Adambean commented 5 years ago

Hi @BOW-el,

Thanks for sending this pull requests. It looks rather good to me! I do have a couple of amendments to make but they're super minor. -- Just some OCD consistency stuff. :)

I'll look into getting that done this evening.

Adambean commented 5 years ago

All done. -- Thanks again for your contribution. :)