search

Adambean / gitlab-ce-ldap-sync

Synchronise users and groups (including group members) from an LDAP instance with Gitlab CE (and EE in free tier) self-hosted instance(s).
Apache License 2.0
59 stars 23 forks source link

Introduce Docker image + ci/cd + cleanup #35

Closed Macleykun closed 1 year ago

Macleykun commented 1 year ago

This still need docs, but i wanted to check if your interested in this. Would ya like to use github registery or dockerhub?

Adambean commented 1 year ago

Just curious as to why you need to delete the VSCode workspace? I can't merge this into master as it is.

Adambean commented 1 year ago

Related: https://github.com/Adambean/gitlab-ce-ldap-sync/issues/33

Macleykun commented 1 year ago

Just curious as to why you need to delete the VSCode workspace? I can't merge this into master as it is.

I found it strange to have someone else’s vscode settings in the project It seemed odd me, and decided to ignore and remove them, however if you prefer to keep those file in the project I’ll revert those files in this pr!

Macleykun commented 1 year ago

fixed it :) Would ya like to use dockerhub or github registery?

Adambean commented 1 year ago

I found it strange to have someone else’s vscode settings in the project It seemed odd me, and decided to ignore and remove them, however if you prefer to keep those file in the project I’ll revert those files in this pr!

The VSCode and Sublime workspace are project specific rather than user specific and are intentionally versioned.

These are legitimately used to recommend (but not enforce) extensions, and to enforce settings deemed important to the project. In the case of this project space, tab, and end of file line settings are defined to help the project comply with PSR-1 and PSR-12. (Though they don't enforce every rule from those.)

Macleykun commented 1 year ago

I found it strange to have someone else’s vscode settings in the project It seemed odd me, and decided to ignore and remove them, however if you prefer to keep those file in the project I’ll revert those files in this pr!

The VSCode and Sublime workspace are project specific rather than user specific and are intentionally versioned.

These are legitimately used to recommend (but not enforce) extensions, and to enforce settings deemed important to the project. In the case of this project space, tab, and end of file line settings are defined to help the project comply with PSR-1 and PSR-12. (Though they don't enforce every rule from those.)

Understood! Revert the git ignore aswell!

Macleykun commented 1 year ago

Heya, is the pr good for ya?

Adambean commented 1 year ago

Thanks for that @Macleykun, merge accepted.