search

Adambean / gitlab-ce-ldap-sync

Synchronise users and groups (including group members) from an LDAP instance with Gitlab CE (and EE in free tier) self-hosted instance(s).
Apache License 2.0
61 stars 23 forks source link

Skip ignored users during group sync #41

Closed vigen-b closed 8 months ago

vigen-b commented 9 months ago

Description

Fix for #40

What's Changed

Adambean commented 9 months ago

Thanks for submitting this. I think the code is correct, spot on in fact. :) I'm checking if it's perhaps happening at the wrong place.

This change will resolve ignored users being unintentionally deleted from a user group, which is fine, though perhaps this check should happen sooner to avoid ignored users being added to a group too. I'll check what happens if your amendment is positioned at line 1874 instead, just after the check for built-in user names, as these two checks are often paired up. You could be completely correct where it already is though.

vigen-b commented 9 months ago

Seems it's better idea, at least user skipping would be handled in one place.