Adambean / gitlab-ce-ldap-sync

Synchronise users and groups (including group members) from an LDAP instance with Gitlab CE (and EE in free tier) self-hosted instance(s).
Apache License 2.0
61 stars 23 forks source link

Passwords should not be set #9

Open frafra opened 5 years ago

frafra commented 5 years ago

Passwords should not be set for LDAP users. GitLab API shows that password is an optional field: https://docs.gitlab.com/ce/api/users.html#user-creation

Adambean commented 5 years ago

Hi Fran,

I agree, though I had to have a password set for new users or the Gitlab API would reject the creation.

From 818c52cd68c59b213fd44e737d7e9a02d0375e56

generateRandomPassword(): New helper function to generate fairly random passwords for new users, as a user for some reason can't be created without a password. (They'll never need it though!) -- See https://gitlab.com/gitlab-org/gitlab-ce/issues/55426

frafra commented 5 years ago

Ok, thanks for reporting it.