Adamm00 / IPSet_ASUS

Skynet - Advanced IP Blocking For ASUS Routers Using IPSet.
https://www.snbforums.com/threads/release-skynet-router-firewall-security-enhancements.16798/
349 stars 61 forks source link

Currently /32 are ending up in Ranges, when instead they should be in single IP. #119

Closed jumpsmm7 closed 1 year ago

jumpsmm7 commented 1 year ago
Brief Description Of Issue

Current coding places /32 subnets (single IP addresses with subnet indicator) inside the Ranges ipset which greatly reduces the amount of elements that can be placed in here with greater subnets.

I have submitted a pull request that improves the detection and resolves the issue with better Regexp logic through skynet pull request channel.

https://github.com/Adamm00/IPSet_ASUS/pull/122

@Adamm00 I wanted to take the time to illustrate that some of the improvements I added in the pull request above improved the overall list processing times of skynet

image

Adamm00 commented 1 year ago

https://github.com/Adamm00/IPSet_ASUS/commit/f7c0e7a5c4d359132d49f8af028919d69c990fa4