Adamm00 / IPSet_ASUS

Skynet - Advanced IP Blocking For ASUS Routers Using IPSet.
https://www.snbforums.com/threads/release-skynet-router-firewall-security-enhancements.16798/
355 stars 60 forks source link

Hang on Curling Microsoft CDNwhitelist #123

Closed jumpsmm7 closed 1 year ago

jumpsmm7 commented 1 year ago

@Adamm00 I am noticing the curl to the Microsoft endpoints domain sometimes hangs indefinitely. Is there another way we can connect to this? https://github.com/Adamm00/IPSet_ASUS/blob/master/firewall.sh#L880

It is not the regex causing the hang because I observed the hang several times with using no regex. There is something going on where curling for the Microsoft endpoints causes an indefinite hang on occasions.

jumpsmm7 commented 1 year ago

I have been doing some testing, using the csv format appears more reliable.

The new url format for csv would look like

https://endpoints.office.com/endpoints/worldwide?format=csv&clientrequestid="$(cat /proc/sys/kernel/random/uuid)"

If you concur with my test and support this idea, I will put it in the next pull request.

jumpsmm7 commented 1 year ago

Here is a confirmed case where the CDN whitelist for microsoft did not load correctly for a skynet user forcing them to have to whitelist an IP address while trying to access Teams.

https://www.snbforums.com/threads/skynet-keeps-failing-to-start.84901/post-841976

I solved the issue with this pull request.

https://github.com/Adamm00/IPSet_ASUS/pull/124