search

AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.41k stars 288 forks source link

More text goodies #616

Closed SirePi closed 6 years ago

SirePi commented 6 years ago

Couple of simple improvements:

ilexp commented 6 years ago

Quick question about the new /u FormattedText control char: Since C# string already support unicode, why wouldn't you just use a unicode character directly?

SirePi commented 6 years ago

Mostly because the editor (or I should say the editor's font) does not support unicode so it displays them all as squares; after having to import (and use) 20 or so non-latin characters, it became difficult to understand what was written where

But yes, it's mostly an editor-only facility..

ilexp commented 6 years ago

Hmm.. can we remove this from the PR? I agree that the editor situation you described is not great, but I would prefer to address the actual issue (Object Inspector fonts for text property editors), rather than add a new feature to the core that the core itself doesn't actually need.

As a workaround until then, would it work if you copy-paste the text you're editing to external text editor of your choice for affected texts? I usually do this for long texts where the current single-line text editor isn't great either, could work in your case as well.

SirePi commented 6 years ago

Sure, go ahead 😄 just comment out/remove lines 874-889?

ilexp commented 6 years ago

Removing the lines in question sounds good. You or me, whoever gets back here first 👍

SirePi commented 6 years ago

Done

SirePi commented 6 years ago

Well... thinking back about it, there is the case where you are using a font that includes characters in the unicode private range, and as such has no representation, or simply do not correspond to the "standard" meaning of the character.. Of course it's still possible to add the character by hand, or by copying it in the editor and have it displayed as a square, but this would not be solved by an ad-hoc font, which would have the side effect of actually masking the situation. Having the ability to actually type your desired code would help in this kind of situation.

As I said before, it's more like a facility for in-editor editing, doing it programmatically you can always compose your string as you better desire.

Your choice 😄

ilexp commented 6 years ago

You have a point, I'm just not sure this is the "right" way to address the issue - and I think it could pay off to wait with this until things get a bit clearer because more experiences have been made.

ilexp commented 6 years ago

And it's merged. Thanks! 🙂