#637 Add Component Dialog - Githubissues

AdamsLair / duality

a 2D Game Development Framework

https://adamslair.github.io/duality

MIT License

1.41k stars 288 forks source link

#637 Add Component Dialog #648

Closed deanljohnson closed 6 years ago

deanljohnson commented 6 years ago

Summary

Added support for a component search dialog as discussed in #637. The dialog is accessible from the SceneView and from the Object Inspector.

Details

Used the previously named ObjectRefSelectionDialog to provide the selection
Renamed ObjectRefSelectionDialog to SelectionDialog to reflect its more varied use cases
See image for location and look of buttons added to the Object Inspector

ilexp commented 6 years ago

Already looks pretty good 👍 Putting this out for review.

ilexp commented 6 years ago

Code looks good at a glance, will get back to you as soon as I managed to do a quick behavior / usability check.

deanljohnson commented 6 years ago

I've addressed your points except the name of the dialog:

ObjectRefSelectionDialog: doesn't work because it is not generic enough and doesn't always select references ObjectSelectionDialog: my issue with this one is that it does not necessarily select objects (unless we are talking objects as in .NET objects, but that is just too generic). SearchableListSelectionDialog: I feel like the fact that it is searchable is a detail not need in the name SelectionDialog: too generic as to the type of selection taking place

How about ListSelectionDialog?

ilexp commented 6 years ago

Good points for all the names. Let's go with ListSelectionDialog for now.

deanljohnson commented 6 years ago

Renamed.

ilexp commented 6 years ago

Will check out the new version 👍

ilexp commented 6 years ago

Merged. Thanks! 👍