Closed deanljohnson closed 6 years ago
Already looks pretty good 👍 Putting this out for review.
Code looks good at a glance, will get back to you as soon as I managed to do a quick behavior / usability check.
I've addressed your points except the name of the dialog:
ObjectRefSelectionDialog: doesn't work because it is not generic enough and doesn't always select references ObjectSelectionDialog: my issue with this one is that it does not necessarily select objects (unless we are talking objects as in .NET objects, but that is just too generic). SearchableListSelectionDialog: I feel like the fact that it is searchable is a detail not need in the name SelectionDialog: too generic as to the type of selection taking place
How about ListSelectionDialog?
Good points for all the names. Let's go with ListSelectionDialog for now.
Renamed.
Will check out the new version 👍
Merged. Thanks! 👍
Summary
Added support for a component search dialog as discussed in #637. The dialog is accessible from the SceneView and from the Object Inspector.
Details