AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.41k stars 288 forks source link

Package with file license gives incorrect link in the package manager #714

Open gregnk opened 5 years ago

gregnk commented 5 years ago

Summary

I published a package with the following nuspec:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>Gregnk.Duality.Plugins.DualityTools</id>
    <version>1.0.0</version>
    <description>A collection of useful components for the Duality game engine</description>
    <authors>Gregory Karastergios</authors>
    <owners>greg_nk</owners>
    <tags>Duality Plugin Tools</tags>

    <projectUrl>http://gregnk.com/projects/DualityTools.html</projectUrl>
    <repository type="git" url="https://github.com/gregnk/DualityTools.git" />
    <license type="file">LICENSE.md</license>
    <copyright>(C) 2019 Gregory Karastergios</copyright>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <dependencies>
      <dependency id="AdamsLair.Duality" version="3.0.0" />
    </dependencies>
  </metadata>

  <files>
    <file src="DualityTools\bin\Debug\Gregnk.Plugins.DualityTools.core.dll" target="lib\" />
    <file src="DualityTools\bin\Debug\Gregnk.Plugins.DualityTools.core.pdb" target="lib\" />
    <file src="DualityTools\bin\Debug\Gregnk.Plugins.DualityTools.core.xml" target="lib\" />
    <file src="LICENSE.md" target="\" />
  </files>
</package>

The license is defined as a file within the nupkg, however in the package manager it gives a link to an MS article where the license should be.

How to reproduce

Attachments

packageManager

ilexp commented 5 years ago

Labeled it as bug due to counter intuitive / incorrect behavior - internally it's clear that this can't work yet, as no support for embedded licenses has been implemented so far.

To add this, we need to check first whether issue #711 is a prerequisite, then figure out how to present this case to the user. The license link could simply open the file from the local package folder instead of a web URL for example.