ilexp
commented
5 years ago Looked into this a bit and didn't find a way to make it work. There were two issues:
- Projects weren't able to restore packages properly, no references to the dependencies were present. This can be fixed by adding a
<NuGetTargetFramework>net45</NuGetTargetFramework>to the project properties. After that, the packages show up directly under "References" and seem to be available in the code as well, so that's good. - As you mentioned, referenced package binaries are not copied to the build output. I wasn't able to fix that one, and adding a
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>as some internet threads suggest doesn't seem to have an effect.
Overall I'm not sure the new PackageReference style is fully supported for old / PCL style projects. We may need to defer this until switching to .NET Standard (see #573). As far as issue #718 goes, we might have more luck by investigating nuget pack-style options.
Unless you still have some options to try or want to investigate further, I'd close this PR without merge.
Barsonax
Migration went pretty smooth but noticed some build errors:
Seems it does not copy some references to the build output folder for some reason. Not sure why. I tested it with a .NET framework console app and it works correctly in that case so it might be that the portable target is causing issues here.