AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.4k stars 289 forks source link

Consider switching to package reference #736

Closed Barsonax closed 5 years ago

Barsonax commented 5 years ago

Summary

Consider migrating all projects to package reference. This is already done with success on my netstandard branch (https://github.com/Barsonax/duality/tree/feature/netstandard_barsonax)

To do this you can either look at my branch for the needed changes or use the migration tool. The latter does a good job of migrating. One thing you do need to do manually is to modify the Copy tasks a bit. Taken from #573:

For this I found a solution since the buildoutput is no longer copied to the build output folder with package reference:

Add GeneratePathProperty="true" on the packagereference: https://github.com/Barsonax/duality/blob/feature/netstandard_barsonax/Source/Core/Duality/Duality.csproj#L11 You can now use $(PkgPackageNameWithUnderscoresInsteadOfDots) to refer to the package path: https://github.com/Barsonax/duality/blob/feature/netstandard_barsonax/Source/Core/Duality/Duality.csproj#L97

After this is done we also need to update my netstandard branch to solve the conflicts that will arise.

Analysis

ilexp commented 5 years ago

Addressed in #739. Closing this.