search

AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.4k stars 291 forks source link

Fix NVorbis warning #797

Closed Barsonax closed 4 years ago

Barsonax commented 4 years ago

Summary

Currently NVorbis is generating a warning that it cannot be references from netstandard because it build with netframework 4.5. Because this warning will end up in user projects we should strive to fix it.

Warning NU1701  Package 'AdamsLair.NVorbis 0.7.6' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project

We are using a fork of nvorbis currently but it seems there is also a nuget package nowadays from the makers of nvorbis themselves which does support netstandard: https://www.nuget.org/packages/NVorbis https://github.com/NVorbis/NVorbis

Alternatively we could try see if simply changing the target framework in https://github.com/AdamsLair/nvorbis and publishing a new package will work.

Barsonax commented 4 years ago

Made a draft PR in #798 to test this. So far the code compiles and unit tests are green but need to do more testing