search

AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.4k stars 291 forks source link

Fixed margin drawing in TilesetCompiler #819

Closed Seti-0 closed 4 years ago

ilexp commented 4 years ago

@Barsonax @SirePi Do you have time to do a quick review by testing the change locally? Maybe run the tilemaps sample and import a second non-square tilemap, verify that both work as expected. If not, I can take this one soon-ish.

When this is merged, we can do a v3.x package release with the fix by running the package update script and merging into release, which I'd leave to you guys.

SirePi commented 4 years ago

@ilexp well, I arrived here, but now I'm stuck at the update version bit, as I can't update because I need to change the path for git in the updater, but if I do it complains that I can't update with uncommitted changes, which I don't want to commit 😂

EDIT: I followed all the steps (I believe) but something's wrong with the release.. it built all packages properly but in the end there's a bunch of version mismatch. Can you check appveyor?

ilexp commented 4 years ago

@AdamsLair/duality-core Managed to fix it, here's a summary FYI:

As it turns out, I branched off archive/v3.x a little too early - there was another package release after that (Duality v3.2.1), so the release branch was more up to date than the archive branch. All was fine, but when the package update script ran, it of course used the old dependency versions from the archive branch. After merging into release, those versions mismatched with the actual versions on that branch. End result: No packages were released.

I fixed this by bringing the v3.x branch up-to-date, rerunning the version updater script and re-merging into release. The packages should now be on their way, and the issue should not happen again in the future.

@Seti-0 None of this had anything to do with your contribution by the way. Thanks, and congrats to your first merged PR! 🙂