AdamsLair / duality

a 2D Game Development Framework
https://adamslair.github.io/duality
MIT License
1.41k stars 287 forks source link

Auto-adjust LauncherPath in Duality solution template to match executable name #848

Closed ilexp closed 4 years ago

ilexp commented 4 years ago

Summary

As mentioned in this comment from PR #840, related to issue #847, the Duality solution template renames the launcher executable to match the project name. However, this leaves the editor without working run, debug and profile buttons. This should be fixed by providing an auto-adjusted EditorUserData.xml in the solution template.

Analysis

Barsonax commented 4 years ago

We can also add a EditorAppData.xml that has to be added to source control and which can contain settings that are not only for the current user such as this path. We should avoid creating another works on my machine situation.

ilexp commented 4 years ago

That would also be an option! And slightly increase scope of the issue, but we might have good use for that kind of data storage in the long run.

However, I'd propose to call it ProjectSettings.xml instead, as (in my head at least) it states its purpose more clearly and draws a useful parallel to what people know from Unity.

Barsonax commented 4 years ago

That would also be an option! And slightly increase scope of the issue, but we might have good use for that kind of data storage in the long run.

Yeah but I think its worth it as like you said there are good use cases for that kind of data storage

However, I'd propose to call it ProjectSettings.xml instead, as (in my head at least) it states its purpose more clearly and draws a useful parallel to what people know from Unity.

Sounds good