updated logviewsettings

AdamsLair / duality

a 2D Game Development Framework

https://adamslair.github.io/duality

MIT License

1.41k stars 289 forks source link

updated logviewsettings #868

Closed Barsonax closed 4 years ago

ilexp commented 4 years ago

Progress

Merged that latest changes from #865 and subsequent tweaks from master into this branch.
Prepared a first draft on how the new settings object for the LogView plugin could be used, see this comment for background info.

ToDo

Discuss and tweak the draft. If we're happy with it, proceed:
Add XML docs for LogViewSettings class and members.
Add XML docs to all added API in LogView.
(Squash-)Merge PR and applying the same principle when addressing the others linked in #855.

ilexp commented 4 years ago

Ping @Barsonax, since I can't request a review from you.

Barsonax commented 4 years ago

Looks good. One thing is that I see you merged master into this branch. Its cleaner to rebase this branch on master as that prevents the merge commit from being generated. Rebasing simply puts the new commits of this branch on top of master so you end up with a cleaner history.

Barsonax commented 4 years ago

Can't approve since its my own PR so gonna to that by comment: Approved.

Merging this.