Fix display of version info to no longer include launcher version.

AdamsLair / duality

a 2D Game Development Framework

https://adamslair.github.io/duality

MIT License

1.4k stars 290 forks source link

Fix display of version info to no longer include launcher version. #876

Closed TheRut closed 3 years ago

TheRut commented 3 years ago

Found this bug while exploring the codebase, which was preventing the About dialog from displaying.

Barsonax commented 3 years ago

Thanks for making the PR.

I was able to reproduce this and found that I broke this in 5e484144224376f69aa1754ae728495d6ea76e28. I don't think we should put a try catch around this though but rather just change labelVersionData.text to be "{0}\r\n{1}" instead of "{0}\r\n{1}\r\n{2}" so that the error won't happen anymore.

TheRut commented 3 years ago

Removed the try/catch. I did leave the update to the form layout so that the click-to-copy functionality captures the version information now (which I believe was the intent).

Barsonax commented 3 years ago

Ok, will try to test this soon

EDIT: @ilexp @SirePi also feel free to test this out

Barsonax commented 3 years ago

Squash merged from mobile :)