search

Adanos020 / egui_dock

Docking support for egui – an immediate-mode GUI library for Rust
MIT License
458 stars 75 forks source link

add overriding tab bar and allowed splits on a per node and surface basis #253

Open 0xcaff opened 1 month ago

0xcaff commented 1 month ago

these changes are made in a backwards compatible way.

i'm looking for feedback on naming, i think it could be more clear. maybe docking override?

also maybe the example could be made a bit more clear? maybe i should move it out of hello or put it behind a flag?

0xcaff commented 1 month ago

I agree. I avoided this design as it involved making a breaking change. If we're happy to break the API, I'm happy to do things this simpler way.

Also, as posted in discord:

After thinking about it a bit, the concept needs a bit more work. I decided to vendor the dependency for now and make whatever changes to understand what exactly I'm trying to do. Currently, if all the tabs are closed from a pane and the parent node is no dock, it will not be possible to open that pane again. This is kinda a weird UX.

Do we want to proceed with the proposed changes or spend more time figuring out what is ideal?

Adanos020 commented 1 month ago

I think we should prioritise usability over backwards compatibility. Especially since we're still in 0.x :wink: NoDock could also be a separate feature, worked on in a different PR if it's a bit of a pain to design properly.