search

AdaptableTools / ballast-trading-poc

0 stars 0 forks source link

Add column for RejectCnt #17

Closed BallastDevelopment closed 2 years ago

BallastDevelopment commented 2 years ago

Can you please add a single column that will display the RejectCnt of each row. Meaning, the the cell for each will show the Reject Count for all keys (Buy, Sell, AUTO_EYE, QUOTING, etc.).

Message example is: {"MessageType":"DATA_UPDATE","Version":1,"DataType":"STRATEGY_DATA","Key":"QUOTING.BITFINEX.TESTBTC:TESTUSD.BUY.1","Name":"RejectCnt","Type":2,"Value":5}

While it it possible (even likely) to receive RejectCnt updates for more than just a single key, we should aggregate the values for the row.

andreifloricel commented 2 years ago

Implemented & Deployed, please close if implementation is as specified

BallastDevelopment commented 2 years ago

Looks good.

  1. Possible to display the count without decimal places?
  2. Possible to have the cell turn color (light red, or light pink) for short interval when count increases?
  3. Possible to show with a tooltip (when hovering over cell) the breakdown of the rejects?
    Something like: AE.Sell 4 | AE.Buy 0 | Q.Sell(1) 3 | Q.Buy(1) 0 Q.Buy(1) 4

I put the quoting level in '( )' because I think it made it easier to read (next to another number) than .notation

andreifloricel commented 2 years ago

All of the requirements are possible, but wee should have a talk about this: AdapTable has extensive notifications features, maybe we can come up with even better solutions.

andreifloricel commented 2 years ago

Implemented as specified. As said, there is still room for extending this ;)