AdaptiveComputationLab / simcov

Other
5 stars 10 forks source link

Infection coords with multiple starting infections #8

Closed abbypribis closed 3 years ago

abbypribis commented 3 years ago

What should the infection-coords parameter be set to when the infections parameter is greater than 1? Or is this parameter irrelevant when the number of infections is greater than 1?

stevenhofmeyr commented 3 years ago

Unfortunately, the parameters for the initial infections are a bit confusing and need to be cleared up. They work as follows:

If --infection-coords is specified, it overrides everything, and --infections is ignored.

If --infection-coords is not specified, then --infections indicates the number of initials infection locations, which are randomly determined.

abbypribis commented 3 years ago

Thanks! Just to clarify, when you say --infection-coords is not specified, that means it is set to -1, -1, -1, -1, correct?

stevenhofmeyr commented 3 years ago

Yes, either set to all -1, or not specified in the config file or on the command line.

vsurjadidjaja commented 3 years ago

Hi everyone,

Just wanted to add a note here that setting --infection-coords to -1,-1,-1,-1 does not result in the --infections flag to override it. For me, it resulted in 0 infected cells. The only way I could override --infection-coords with --infections is to comment out the --infection-coords flag.

stevenhofmeyr commented 3 years ago

Thanks for pointing that out, @vsurjadidjaja . I really need to fix the counter-intuitive interplay between these two parameters.