search

AdaptiveConsulting / nexus-casc-plugin

Configuration as code plugin for Sonatype Nexus Repository Manager
MIT License
48 stars 21 forks source link

Add binaries to releases section #10

Open dene14 opened 4 years ago

dene14 commented 4 years ago

There is onlt source code tarballs in releases section on github right now. Can we add binaries (*.kar) in addition or as a replacement for it?

bdellegrazie commented 4 years ago

Hi @dene14 - I'll need to check internally where we can host them. I don't think it will be a huge problem but I haven't thus far because of that.

Just FYI, it is trivially simple to build (JDK 8 + mvn package will get you the .kar file) - i've updated the documentation to include a building section.

dene14 commented 4 years ago

Yeah, I know... I just noticed that you have pipeline anyway, just pushing to your private artifactory.. I believe Github Releases can be used for that... For e.g.: https://github.com/roboll/helmfile/releases

csullivannet commented 3 years ago

Since this project is open source, can it use GitHub Actions for free? I might not be able to get to it for a few weeks, but I could look at using Actions to create and publish the .kar archive.

csullivannet commented 3 years ago

@dene14 @bdellegrazie I've opened a PR that automatically builds and publishes, it generaties artifacts for regular commits and publishes to the release: https://github.com/AdaptiveConsulting/nexus-casc-plugin/pull/12

bdellegrazie commented 3 years ago

@csullivannet I have merged your changed but at present it doesn't look like its producing the artefacts or I haven't tied it in properly. I'll recheck it over the weekend.

csullivannet commented 3 years ago

I can see that you created a release from the commit after you merged the workflow. It should have then kicked off the workflow to create the release bundle.

Let me know how your testing over the weekend goes.

FOTempel commented 1 year ago

Our deployment tooling for Nexus pulls its plugins from https://repo1.maven.org/maven2/org/sonatype/nexus/plugins/, that would be a great place to put it. Having to compile a plugin ourselves would introduce chicken and egg problems as built artifacts belong in an artifact manager which we're trying to deploy, which we can't because there's no CasC (yet)... This can be worked around, sure, by including built binaries in the deployment code, but that's ugly and will introduce new problems.