Closed gwappa closed 1 year ago
Hi @gwappa , great catch, thanks a lot for your bug report.
This seems related to #30 (CC @CeliaBenquet ) , where we started fixing a similar issue for the decoder.
@gonlairo , let's try to convert this issue into a test, move the helper functions in #30 out of cebra/integrations/sklearn/decoder.py
, and then fix the selection of the distribution when another data type is given?
@gwappa , I assume that this issue is not blocking you currently? We will probably address it in an upcoming version of CEBRA.
Thank you very much @gwappa. I'm on it.
Is there an existing issue for this?
Bug description
Hi,
thanks a lot for sharing this nice work!
I happened to use
numpy.uint8
as the discrete label type, and the resulting CEBRA model ended up performing time-contrastive learning (instead of supervised learning using discrete labels).It seems that it requires the labels to have
numpy.int32
ornumpy.int64
data types in order for them to be considered to be discrete: https://github.com/AdaptiveMotorControlLab/CEBRA/blob/main/cebra/integrations/sklearn/dataset.py#L142Is it possible that you guys further support the other integer types for discrete labels?
I found out this StackOverflow post: https://stackoverflow.com/questions/37726830/how-to-determine-if-a-number-is-any-type-of-int-core-or-numpy-signed-or-not
So substituting something like below should theoretically work:
Thank you very much in advance!
Operating System
CEBRA version
cebra version 0.2.0
Device type
Core i9 / RTX 3090
Steps To Reproduce
Something like below should reproduce this issue (unfortunately I write this on another computer: please forgive me for any potential typos)
Relevant log output
No response
Anything else?
No response
Code of Conduct