Add test for consistency plotting; fix plotting for unordered dataset ids - Githubissues

AdaptiveMotorControlLab / CEBRA

Learnable latent embeddings for joint behavioral and neural analysis - Official implementation of CEBRA

https://cebra.ai

Other

884 stars 72 forks source link

Add test for consistency plotting; fix plotting for unordered dataset ids #54

Closed stes closed 11 months ago

stes commented 1 year ago

As noted in #27, when passing non-sorted labels to the consistency plot, the order off values in the confusion matrix does not match the axis labels.

In this PR,

we add a test to cebra_sklearn_metrics.consistency_score(...,between="datasets",...) to detect this issue
propose a fix

Before merging, it would be good to add additional tests especially for the multi-run (vs. multi-dataset) case. Also useful if @CeliaBenquet could review this remaining comment (https://github.com/AdaptiveMotorControlLab/CEBRA/pull/54/files#r1279777840).

Fix https://github.com/AdaptiveMotorControlLab/CEBRA/issues/27

stes commented 11 months ago

close in favor of #87 , thanks @CeliaBenquet !