AdarshKumar712 / MathsDep_Website

Website for the department of Mathematics, IIT Kharagpur
4 stars 19 forks source link

Change home sidebar CSS #13

Closed leonardomaier closed 4 years ago

leonardomaier commented 4 years ago

PR created for issue #10

leonardomaier commented 4 years ago

@AdarshKumar712 check this out.

AdarshKumar712 commented 4 years ago

Do upload a screenshot of the webpage

leonardomaier commented 4 years ago

Based on the reference you sent.

Any changes?

image

leonardomaier commented 4 years ago

@AdarshKumar712 I just saw that you have different menus between the pages. Maybe I could rename the CSS classes to make the style reusable between the pages before you merge this PR. I made this change specific for the home page and later I just realized that is not the same menu between pages.

AdarshKumar712 commented 4 years ago

It's alright for now, once all the styles are finalized, then the changes will be applied to all the relevant pages

AdarshKumar712 commented 4 years ago

Hey @leonardomaier, could you please set these change in CSS so that the change that you made apply to for all the relevant pages?

leonardomaier commented 4 years ago

@AdarshKumar712 sure, should I consider relevant pages as pages containing this type of menu? I will make the changes as soon as possible

AdarshKumar712 commented 4 years ago

Yes, do consider all the relevant pages. I hope you are thinking to make the formatting a part of main.css so as make the changes to the respective class/id, such that the changes get applied to all the pages. Please do correct me if I am wrong.

leonardomaier commented 4 years ago

@AdarshKumar712 yes, that is exactly what I will do.

leonardomaier commented 4 years ago

@AdarshKumar712 I've made the changes.

AdarshKumar712 commented 4 years ago

Could you please do the same for the Login.php as that page also contains the sidebar? Btw Great work @leonardomaier!!!

leonardomaier commented 4 years ago

@AdarshKumar712 done!

rakaar commented 4 years ago

Hey @leonardomaier , Please resolve the conflicts, update your current branch with kwoc branch so that PR can be merged.

leonardomaier commented 4 years ago

@rakaar done!