search

AdarshRaoT / git-basic-operations

0 stars 0 forks source link

Teena's questions #3

Open tmassgov opened 1 month ago

tmassgov commented 1 month ago

Hi Adarsh, I would like to again review the steps of github....could I talk with you today about this. Also testing this issues.

tmassgov commented 1 month ago 
01 Clone a repository, 
02 make a new branch, 
03 make a change, 
04 push to GitHub, (stage, commit, push?)
05 create a Pull Request (PR) to GitHub,  
06 have another team member review the code, 
07 and approve the PR, 
08 and merge
tmassgov commented 1 month ago

I reviewed your pull request from the other day. So, now that I have approved it, do I do the merge or do you do the merge?

AdarshRaoT commented 1 month ago

I reviewed your pull request from the other day. So, now that I have approved it, do I do the merge or do you do the merge?

Thanks for the review Teena! In general, once a pull request (PR) is approved, the person who created the PR usually merges it. However, team preferences can vary. For this project, I can go ahead and merge it unless you’d like to do it. Just let me know what you prefer!

AdarshRaoT commented 1 month ago

Hi Adarsh, I would like to again review the steps of github....could I talk with you today about this. Also testing this issues.

Sure, I can connect at 2:30 if that works for you.