search

AddReminders / Reminders-in-RocketChat

8 stars 0 forks source link

Link to message from remind.bot opens in external browser. #1

Open iglooom opened 2 years ago

iglooom commented 2 years ago

When I click on 'this message' link from reminder it opens in Firefox instead Rocket.Chat app.

Rocket.Chat app version 3.8.4 from flatpack.

I presume it maybe because my default browser is Firefox. Can it be fixed?

You have done a greate job, thanks for this app.

murtaza98 commented 2 years ago

Hi @iglooom Thanks!! Glad you liked the app :smile:

Regarding the redirect link issue you mentioned, unfortunately, I wasn't able to reproduce it. I installed the desktop RC app from snap and tested the feature and it seems to be working fine. It didn't redirect me to outside the app. Check here https://www.loom.com/share/b79cab6132744731939cfbd1932eb076

One issue I can think of would be that the baseUrl for the link of "this message" (i.e. eg http://localhost:3000/channel/general?msg=R8xHLykGgkjpLrDKp) might be different than the URL that you've set up on your RC desktop app i.e. here image

Can you please check if this is the same or not?

tuxmartin commented 2 years ago

Hi, I have the same problem.

Rocket.Chat server 4.6.3 (snap, debian 10).

Add Reminder 2.1.3. from marketplace.

murtaza98 commented 2 years ago

Okay, I'll revisit this @tuxmartin Which OS are u using? Also, what is your version of Rocket.Chat app (Not the core release, but instead the version of the Electron app)?

tuxmartin commented 2 years ago

Rocket.Chat 3.8.6, Ubuntu 21.10 and Rocket.Chat 3.8.6, Windows 10. On both OS I have the same problem.

murtaza98 commented 2 years ago

Just tested with Rocket.Chat 3.8.6 on Ubuntu 20.04 with https://open.rocket.chat and didn't face this issue there. I'll try to replicate your exact versions later today to check this further. In the meantime, @tuxmartin can you please help me with the following info:

  1. Are you able to replicate this issue if you connect your Electron app to the open server? (i.e. https://open.rocket.chat)
  2. Can you share the message link address on the reminder bot-message (it should be something like http://localhost:3000/channel/general?msg=R8xHLykGgkjpLrDKp) and the Site_Url setting from your Rocket.Chat sever
tuxmartin commented 2 years ago

Hi,

  1. How can I test it? There is no reminder app on https://open.rocket.chat

  2. Message link from reminder: https://rc.vancl.eu//group/test?msg=8bBuaMw8JLhSvk9mu Site_Url: https://rc.vancl.eu/

tuxmartin commented 2 years ago

@murtaza98 hi, do you have any news?

murtaza98 commented 2 years ago

Hey @tuxmartin I think I see the issue now. If you notice closely the message link i.e. https://rc.vancl.eu//group/test?msg=8bBuaMw8JLhSvk9mu, it has 2 forward slashes before "group" which is making the desktop app treat this as an external link and hence redirecting you outside RC when clicked on it.

So, I'll update the app to handle this edge case by ignoring the extra slash in the end (Will keep you posted about updates here). In the mean-time, I think you can resolve this on your own server itself by just removing an extra forward slash from the back of your Site_Url setting i.e. convert https://rc.vancl.eu/ -> https://rc.vancl.eu

tuxmartin commented 2 years ago

@murtaza98 hi, I removed / at the end of my Site_Url and I still have the same problem (2.1.3 from Marketplace). Url is now only with single /.

murtaza98 commented 2 years ago

Sorry but I don't have any news here. I'm still struggling to get this issue reproduced in some environment. I already tried the versions you mentioned (3.6.3 RC server & 3.8.6 RC desktop app) but couldn't even reproduce the issue over there :sweat:

murtaza98 commented 1 year ago

Hey guys, I hope you guys are still not facing this issue since I haven't heard any complaints about this in a while.

So I'm closing this issue, however if you're still facing this issue then feel free to contact me and we can re-open it and investigate further

tuxmartin commented 1 year ago

@murtaza98 it's still broken. (Rocket.Chat 5.2.0, Add Reminder 2.3.0).

murtaza98 commented 1 year ago

Ouch, sorry to hear it. @tuxmartin Unfortunately I'm still not able to reproduce this issue in any environment so it's really hard for me to debug this further and offer any solution. May I ask, if it is possible to give me temporary access to one of your environments where this issue is happening, or perhaps a small video call, so I can investigate it further? Appreciate any help over here :pray:

Here are my contact details: Open server of Rocket.Chat LinkedIn