search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
783 stars 131 forks source link

Ember-cli and javascript #112

Closed jordansmith42 closed 9 years ago

jordansmith42 commented 9 years ago

Ports all code from coffeescript to javascript Changes build to run through ember-cli Maintains backwards compatibility through globals build run through grunt dist Updates readme

A huge thanks to @artych for porting all the code to javascript and setting up ember-cli

jordansmith42 commented 9 years ago

Reviewing the build scripts for the global build is probably the biggest change that isn't a port from coffeescript to javascript, gruntfile, brocfile and everything in the packaging directory.

embooglement commented 9 years ago

LGTM after addressing @cyril-sf's comments

thangdinh commented 9 years ago

wow, LGTM comes so fast!

cyril-sf commented 9 years ago

@jordansmith42 I made a few comments

jordansmith42 commented 9 years ago

@cyril-sf Updated readme/changelog are we good?