Closed billy-addepar closed 8 years ago
So this one is not backward compatible? i.e. if people are using ember-charts and this upgrade will break their existing code base where they set the hasAxisTitles
.
We probably should support backward compatibility here.
I agree with Thang, if we can support backwards compatibility here we probably should, otherwise we'll have to do a major version bump.
backward compatibility supported.
@thangdinh @embooglement
Comments addressed + tests added
what will happen if we have a long title?
@xudaniel11work for the long title question
Also @jordansmith42 for that question. It's not supported in master branch now.
@thangdinh that's an edge case that we should look into but shouldn't block this, it seems very rare that a title would be longer than the entire chart width
Comments addressed
LGTM if all the comments have been addressed
This PR aims to do:
hasAxisTitles
intohasXAxisTitle
andhasYxisTitle
to have more granular configuration for X & Y axis titleslegendChartPadding
to be dependent on height of axis titles. ThelegendChartPadding
is move fromscatter-chart.js
intoaxis-titles.js
mixin.@jordansmith42 @philpee2 @embooglement