Try to make mixed charts more flush

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/

Other

784 stars 131 forks source link

Closed pnachum closed 8 years ago

pnachum commented 8 years ago

Opening for discussion.

Updated screenshots:

pnachum commented 8 years ago

@Addepar/fire

pnachum commented 8 years ago

It fails when the longest grouping label on one side is longer than the longest bar + its value label on the same side

pnachum commented 8 years ago

@Addepar/fire Updated with logic borrowed from Akhilesh's PR. Somewhat more verbose, but I think it should be clear. Let me know if it makes sense.

akhileshgupta commented 8 years ago

Just tried it out.. Looks good. Will do more testing tonight.

pnachum commented 8 years ago

@Addepar/fire This is ready for review.

I have another commit in the works which adds a bunch of tests for some of the new logic we've added lately. Tests for this will go in alongside that

pnachum commented 8 years ago

@Addepar/fire other concerns?

pnachum commented 8 years ago

@thangdinh @Addepar/fire Any other concerns?

embooglement commented 8 years ago

LGTM