search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
783 stars 131 forks source link

Rounded Zero Percent Slice Configurations for Pie Charts #181

Closed xudaniel11work closed 8 years ago

xudaniel11work commented 8 years ago

This branch fixes rounding errors and adds the missing Other Slice when the Other Slice is incorrectly rounded to 0%. It also adds a toggle to allow users to include / exclude zero percent slices. These 0% slices respect slice ordering and number of decimal points. Finally, it contains tests for all of the above.

See screenshots for examples

With "Include Rounded Zero Percent Slice" Off

screenshot 2016-08-25 21 29 29

With "Include Rounded Zero Percent Slice" On (Default)

screenshot 2016-08-25 21 29 33

With decimal places inside the Pie Chart

screenshot 2016-08-25 21 29 37
xudaniel11work commented 8 years ago

retest

xudaniel11work commented 8 years ago

retest

shiller-addepar commented 8 years ago

Tests and jazz look good to me. I'd like someone else to either dismiss or jump on the number precision bandwagon. Likely there aren't a lot (or the right type) of users who would care about this distinction.

xudaniel11work commented 8 years ago

@shiller-addepar thanks for the review! Should I take that as an LGTM?

shiller-addepar commented 8 years ago

LGTM! Sorry, It got cut off the last comment >_<

xudaniel11work commented 8 years ago

Sounds good! Merging now