search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Fix #173 regression: Vertical Bar Charts ignore bar-specific color overrides #182

Closed metathinker closed 8 years ago

metathinker commented 8 years ago

For each bar data point in a vertical bar chart, you can specify the color for that bar explicitly. This feature should be documented in the API here: http://opensource.addepar.com/ember-charts/#/documentation under Vertical-Bar Options, data property, but unfortunately the documentation is currently missing this information.

Unfortunately, pull request #173 caused us to ignore these colors. We didn't discover this bug until we tried to wire up a build of Ember Charts with #173 to Addepar's own application. Bad, very bad of us, and we are sorry.

This changeset fixes the regression. A new test is added to catch it.

Nominated reviewers: @BillyLittlefield @Addepar/fire

billylittlefield commented 8 years ago

LGTM

metathinker commented 8 years ago

Thanks!