search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Hover labels for Line Series with Overridable Date function #198

Closed shiller-addepar closed 7 years ago

shiller-addepar commented 7 years ago

We found an issue that when a REALLY small graph is generated, that the labels for the line series can be pushed or pulled by a day. Since we have the data when updating the line, we can simply copy what we do for bar charts and override the tool tip.

All of that to say that I've identified a need where a user may need to provide a custom function for their labeling that enables them to tweak the time slightly.

jordansmith42 commented 7 years ago

tests?

shiller-addepar commented 7 years ago

@jordansmith42 I'd need a spy to get in the way of the evocation of the adjustTimeForShowDetails to test it here (to override the passthrough functionality that is there). In the implementation it'll be much easier to test ^_^