Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Remove mouseover event on time-series path #200

Closed billylittlefield closed 7 years ago

billylittlefield commented 7 years ago

Cherry-picks the last commit (that close #199) from master into Addepar branch: https://github.com/Addepar/ember-charts/commit/2598639161594a0b6590cfc8806545670405a22c

Currently, time series line charts have two mouseover events that can fire -- one attached to line, and one attached to the dot that appears when hovering. The data being passed into showDetails for the line's mouseover event contains all data for the line, not a specific point. In short, this mouseover event was not doing anything except throwing errors whenever it was fired, because showDetails expects data for a single point. The correct data for a point is passed in the line marker's mouseover event, found in updateLineMarkers (in has-time-series-rule.js).