search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

HTTP to HTTPS and remove target="_blank" a-attribute #223

Closed faf0-addepar closed 5 years ago

faf0-addepar commented 5 years ago

The target="_blank" a-attributes are removed to prevent phishing: https://dev.to/ben/the-targetblank-vulnerability-by-example

Correct the bower registry to fix build.

metathinker commented 5 years ago

You also need to correct the failing test case: not ok 198 PhantomJS 2.1 - Unit | Mixin | legends: drwaing legend works

faf0-addepar commented 5 years ago

@metathinker thanks for taking a look. I reverted the XML namespace changes.

The reason to remove the target="_blank" attributes is to prevent phishing: https://dev.to/ben/the-targetblank-vulnerability-by-example