search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Scope text styles to ember-charts only #229

Closed twokul closed 5 years ago

mixonic commented 5 years ago

We've discussed this a bit- It might be nice to keep this style in place but simply scope it appropriately so it only applies to svg elements outputted by ember-charts. This might mean adding a class to svg elements that ember-charts outputs.

It actually seems like all the svg styles in that file should be scoped only to svg elements from ember-charts.

twokul commented 5 years ago

just for the context - @mixonic and I agreed (offline) that a proper fix would be to either add a new class to svg element or to wrap all current styles in .chart-frame {. I will follow up w/ that change.