search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

[CHORE] Fix memory leaks linked to the mouse event handlers #231

Closed cyril-sf closed 5 years ago

mixonic commented 5 years ago

@cyril-sf Oof. I both think this is reasonable, and I am suspicious you are looking at gc-able but not-yet-gc'd objects in the retainer tree. Are you forcing GC before looking at the tree?

cyril-sf commented 5 years ago

@mixonic I'm using the test suite of our application as a reference point.

Screen Shot 2019-04-25 at 2 22 40 PM

At some point, Chrome literally paused the tests automatically Screen Shot 2019-04-25 at 2 21 24 PM

This PR prevents that problem by decreasing the memory usage when running tests.