search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Revert "[BUG] Don't trigger unnecessary computation during teardown" #236

Closed mixonic closed 5 years ago

mixonic commented 5 years ago

This reverts:

The teardown solution used in #234 re-invokes volatile CPs. During un-rendering of an application, the invocations may attempt to calculate based on no-longer-valid state.

Furthermore afaik d3 instances should be exit() and remove(), and the handlers will be GC'd by Chrome. There is possibly something going on here and this is possibly a mitigation or fix, but neither of those PRs actually describe what is going on in more detail than "event handlers should be removed" (which is guidance that does not apply to Chrome).

mixonic commented 5 years ago

I may have resolved this in another manner downstream. I remain suspicious about what is actually happening in this code.