search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Upgrade Ember-CLI #240

Closed mixonic closed 5 years ago

twokul commented 5 years ago

@mixonic are you sure we can kill dependencies folder w/o it impacting opensource.addepar.com?

rondale-sc commented 5 years ago

@mixonic What was the dependencies folder used for previous to this commit? Seems as if most of those files were removed?

mixonic commented 5 years ago

@rondale-sc @twokul the entire dependencies/ folder is removed. AFAICT these are legacy files which are not used in the addon. This is backed up by: a) the files in that folder last changed over 5 years ago b) the codebase doesn't seem to reference dependencies in a way that references that folder c) the contents of many of the files are precompiled Ember templates for an old version of Ember (pre-1.10 I think).

Based on that and our conversation over Slack, I think we're a go 👍