search

Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Austin/webcore 264 - Remove Less #247

Closed aschenoni closed 4 years ago

aschenoni commented 4 years ago

Removes less as a dependency to the addon and the dummy app.

The actual changes to the addon are very minimal, with a single less file converted to css. The real "work" of this PR was fixing the dummy app and its usage of less. The dummy app contained several less files including an imported dependency on bootstrap.less.

I went with the "naive" approach of transpiling the main .less file into the corresponding .css file in place. It may be slightly less maintainable but the approach has a lower chance of introducing a breaking change. I also chose to decouple the bootstrap import for better management of that dependency outside of the dummy app's styles and it's now included via ember-cli-build.js.

aschenoni commented 4 years ago

Iverson CI passes with a draft PR of this hash as a dependency. Visual check of old charts passes.