Addepar / ember-charts

https://opensource.addepar.com/ember-charts/
Other
784 stars 131 forks source link

Refactor computed properties to avoid deprecated combined getter setters #248

Closed mmun closed 4 years ago

mmun commented 4 years ago

This PR refactor computed properties to avoid deprecated combined getter setters into the modern split getter/setter styles.

I could have tried to dedupe the getter and setters paths a bit better but I didn't want to risk messing up the logic as I'm not familiar with this code.

Ultimately, I think the real solution is to refactor away from having this kind of logic in setters entirely so I went with the straightforward refactor.